Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: refactored createFullfacetPipeline function #806

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Refactor: refactored createFullfacetPipeline function #806

merged 5 commits into from
Oct 18, 2023

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Oct 16, 2023 •
edited
Loading

Description

Improved readability by reducing use case of else if condition

Motivation

It was extremely hard to read what's going on inside createFullfacetPipeline function

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@Junjiequan Junjiequan marked this pull request as ready for review October 16, 2023 08:10
@Junjiequan Junjiequan changed the title Swap 3559 elastic search refactor fullfacet for elastic sea Refactor: refactored createFullfacetPipeline function Oct 16, 2023
bpedersen2
bpedersen2 requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the eslint comment( T is unsed in handleScientifcQuery) on line 564

src/common/utils.ts Outdated Show resolved Hide resolved
@Junjiequan Junjiequan requested a review from bpedersen2 October 16, 2023 10:45
@nitrosx
Copy link
Contributor

nitrosx commented Oct 18, 2023

@Junjiequan Can you please resolve the conflict?

@nitrosx nitrosx merged commit 531e2c3 into master Oct 18, 2023
8 checks passed
@nitrosx nitrosx deleted the SWAP-3559-elastic-search-refactor-fullfacet-for-elastic-sea branch October 18, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrosx nitrosx nitrosx approved these changes

@bpedersen2 bpedersen2 Awaiting requested review from bpedersen2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Junjiequan @nitrosx @bpedersen2